@damtsnkff thanks for your PR. I saw your preview commit too dd87168 Very nice, 👍

In main project IBAnimatable, there are two targets. IBAnimatable target is a framework tareget. and IBAnimatableApp is an app target, which is a demo app.

I think having an example app is good for the project sepically for developing the new features. We can valify the feature by testing the example app.

Also we don't distribute the example app when we create the framework (using CocoaPods, Carthage or Swift Package Manager) for the users. For IBAnimatable-Material project, we will creat a framework target and move all Animatable<MaterialElements> classes into this target and create a Pod for it. Also create an app target to contain all demo features. MainTableView and all storyboards will be in the app target only. App target will use IBAnimatable-Material target as a framework. Same as what we are doing in `IBAnimatable.

Later on, the user can use CocoaPods, Carthage or Swift Package Manager to use IBAnimatable-Material. IBAnimatable-Material pod will depend on IBAnimatable and Material pods.

Did I answer your question? Please let me know if you have any questions.

Using the same architecture as IBAnimatable makes sense, avoid the confusion, and will be easier to understand. Can I do the modification and then commit on the same PR or should I modify and create another PR ?

To sum up the modifications to make to this PR :

• Create a Framework target with Animatable<MaterialElements> classes
• Create an App target, that use the new IBAnimatable-Material Framework
• Organize the workspace folders in consequence

Is this all for this PR?

Related to #3

Hi Damien,

it's up to you to merge current one and create another PR for the frameworks. Or you close it and create a new PR only. We don't have restricted rule. Please let me know if you have any questions.

Jake

Sent from my iPhone

On 13 Jul 2016, at 1:12 AM, Damien Tsnkff [email protected] wrote:

Using the same architecture as IBAnimatable makes sense, avoid the confusion, and will be easier to understand. Can I do the modification and then commit on the same PR or should I modify and create another PR ?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@JakeLin If I merge this one, isn't that going to have conflict with #4 ?
Next PR will be the Framework structure #3 (then another one for the dependency managers #6 ).

I won't be a conflict because we can rebase the next one. If there is a conflict, we can do it together to resolve it. Git is very good for resolving conflicts.

Sent from my iPhone

On 13 Jul 2016, at 9:36 AM, Damien Tsnkff [email protected] wrote:

@JakeLin If I merge this one, isn't that going to have conflict with #4 ?
Next PR will be the Framework structure #3 (then another one for the dependency managers #6 ).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.